Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sopel: use python3 style class and abc.ABC #2138

Merged
merged 3 commits into from
Sep 23, 2021
Merged

sopel: use python3 style class and abc.ABC #2138

merged 3 commits into from
Sep 23, 2021

Commits on Aug 29, 2021

  1. sopel: use python3 style class 

    In Python 2, there was 2 styles:

* `class ClassName:`
* `class ClassName(object)`

And they behaved differently, and using `super()` is different too.
However, in Python3, both are equivalent to doing the second style,
and we can use `super()` directly.

So, yeah. Yet another weird thing about py2/py3.
    @Exirel
    Exirel committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    cea6463 View commit details
    Browse the repository at this point in the history

  2. sopel: use abc.ABC baseclass for abstract classes 

    And also add some type hint when easy to do so.
    @Exirel
    Exirel committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    d053712 View commit details
    Browse the repository at this point in the history

  3. rules: add more type hint for match and parse

    @Exirel
    Exirel committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    9f83a59 View commit details
    Browse the repository at this point in the history