Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: replace git.io link with shortcut defined on sopel.chat #2271

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

dgw
Copy link
Member

@dgw dgw commented Apr 20, 2022

Description

Prerequisite: sopel-irc/sopel.chat#37

Tin. I don't mind one bit bundling this with the next bugfix release. We're just changing the link so it's guaranteed to keep working even if GitHub kills off git.io entirely without warning (kind of like they announced it would stop accepting new links without warning, so I don't think this is paranoid).

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Turns out it was pretty easy to set up a redirect to anything at all
since sopel.chat runs on Netlify. More importantly, it will still be
easy even if the site switches to (almost) any other static-site host
or goes back to running on someone's Apache/Nginx/Caddy/whatever box.
@dgw dgw added the Tweak label Apr 20, 2022
@dgw dgw added this to the 7.1.9 milestone Apr 20, 2022
@dgw dgw requested a review from a team April 20, 2022 05:05
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgw
Copy link
Member Author

dgw commented Apr 27, 2022

God damn it, GitHub. I did this as a hedge but never expected the shutdown would happen this month. https://github.blog/changelog/2022-04-25-git-io-deprecation/

Guess 7.1.9 is going out on Friday.

@dgw
Copy link
Member Author

dgw commented Apr 28, 2022

GH updated yesterday to say they now plan to create a read-only archive service. You know, the thing they should have done in the first place—and what they effectively already have, from an outsider's perspective.

Clearly there's something about the current infrastructure they don't like. We're still going to move this link off of git.io, of course, but the urgency is now slightly reduced.

Thought about the redirects a bit more, and really didn't like any of my
ideas for a keyword. Side-stepped the whole thing by setting up wildcard
redirection of issue & PR numbers.
@dgw
Copy link
Member Author

dgw commented Apr 29, 2022

Verified the new shortcut is working on the live site after deploying sopel-irc/sopel.chat#37 earlier today. Let's go!

@dgw dgw merged commit d111d93 into master Apr 29, 2022
@dgw dgw deleted the search-git.io branch April 29, 2022 06:17
dgw added a commit that referenced this pull request Apr 29, 2022
search: replace git.io link with shortcut defined on sopel.chat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants