Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename contest leaderboard to score leaderboard #1064

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

DesSnowy
Copy link
Contributor

This pull request changes the type of the JSON returned from contestLeaderboard to scoreLeaderboard in order to accompany the changes in Frontend.

Type of change

  • Rename contest leaderboard to score leaderboard
  • Update test cases to match

In preparation of new feature which shows contest leaderboard based on votes
@coveralls
Copy link

Coverage Status

coverage: 95.257%. remained the same
when pulling a09f5e7 on DesSnowy:RenameContestLeaderboard
into ace47cd on source-academy:master.

@RichDom2185
Copy link
Member

Corresponding frontend PR: source-academy/frontend#2779

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we only need to change the view layer (as done in this PR) – I don't think we need to change the model layer. Thanks!

@RichDom2185 RichDom2185 merged commit dba4f95 into source-academy:master Feb 13, 2024
2 checks passed
@DesSnowy DesSnowy deleted the RenameContestLeaderboard branch February 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants