-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename contest leaderboard to score leaderboard #2779
Rename contest leaderboard to score leaderboard #2779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for working on this, just a minor clarification below:
src/features/envVisualizer/__tests__/__snapshots__/EnvVisualizer.tsx.snap
Outdated
Show resolved
Hide resolved
Blocked by WIP corresponding backend PR. |
2089999
to
e2c765a
Compare
Pull Request Test Coverage Report for Build 7882291453Details
💛 - Coveralls |
Corresponding backend PR: source-academy/backend#1064 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
This pull request changes the name of the contest leaderboard tabs and relevant strings to "Score Leaderboard." This is done in preparation for adding a new popular votes leaderboard and differentiating it from the usual contest leaderboard.
Type of change
Checklist