Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename contest leaderboard to score leaderboard #2779

Merged

Conversation

jayjay19630
Copy link
Contributor

@jayjay19630 jayjay19630 commented Feb 13, 2024

Description

This pull request changes the name of the contest leaderboard tabs and relevant strings to "Score Leaderboard." This is done in preparation for adding a new popular votes leaderboard and differentiating it from the usual contest leaderboard.

Type of change

  • Rename contest leaderboard to score leaderboard
  • Update snapshots

Checklist

  • I have tested this code

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this, just a minor clarification below:

@RichDom2185 RichDom2185 added the blocked Something else needs pass review first label Feb 13, 2024
@RichDom2185
Copy link
Member

Blocked by WIP corresponding backend PR.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7882291453

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.196%

Totals Coverage Status
Change from base Build 7872141124: 0.0%
Covered Lines: 5723
Relevant Lines: 14462

💛 - Coveralls

@RichDom2185 RichDom2185 removed the blocked Something else needs pass review first label Feb 13, 2024
@RichDom2185
Copy link
Member

Corresponding backend PR: source-academy/backend#1064

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 1208290 into source-academy:master Feb 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants