✨ feat: add total xp table #2281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3870115319Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
RichDom2185
reviewed
Dec 21, 2022
Member
RichDom2185
left a comment
RichDom2185
left a comment
There was a problem hiding this comment.
Understand that there were time constraints involved hence the priority was to get things working at the time, but if you don't mind, could you take another look at the potential code quality improvements below?
chownces
reviewed
Jan 8, 2023
chownces
approved these changes
Jan 9, 2023
shenyih0ng
pushed a commit
that referenced
this pull request
Jan 9, 2023
* ✨ feat: add api call to redux and saga * ✨ feat: add new Xp Calculation page * ✨ feat: add nav-link to new page * 🧪 tests: add academy navigation bar test * ✨ feat: add conditional render for xp calculation * 🧪 tests: remove unused snapshot * use React.FC typing for component * shift constants out of react component * memoize callbacks as per PR comment * remove commented out table filter code * shift to useDispatch * update actions to fit naming convention Co-authored-by: En Rong <53928333+chownces@users.noreply.github.com>
Member
|
As discussed offline, we will revert this. Unfortunately, this is hundreds of commits behind the main branch so we'll have to create the revert commit manually. |
RichDom2185
added a commit
that referenced
this pull request
Feb 13, 2024
This reverts commit d47cc0e.
7 tasks
RichDom2185
added a commit
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a total XP table so that admins can view the
total xpof all students and download a CSV of all their total XP.Type of change
Checklist
Screenshots