Skip to content

Conversation

@RichDom2185
Copy link
Member

Description

This PR reverts the changes in #2281 as per what was discussed offline, due to its corresponding backend PR source-academy/backend#914 not being merged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Everything should still work. Compare the diffs between the two PRs; though lots of refactors have been done since, they should still make sense.

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-assigned this Feb 13, 2024
@RichDom2185 RichDom2185 changed the title Revert "✨ feat: add total xp table #2281" Revert ":sparkles: feat: add total xp table (#2281)" Feb 13, 2024
@RichDom2185 RichDom2185 changed the title Revert ":sparkles: feat: add total xp table (#2281)" Revert "Add total XP table" feature Feb 13, 2024
@coveralls
Copy link

coveralls commented Feb 13, 2024

Pull Request Test Coverage Report for Build 7890237329

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 37.396%

Files with Coverage Reduction New Missed Lines %
src/pages/academy/Academy.tsx 1 0.0%
Totals Coverage Status
Change from base Build 7890035645: 0.2%
Covered Lines: 5739
Relevant Lines: 14438

💛 - Coveralls

@RichDom2185 RichDom2185 merged commit 60eb5e2 into master Feb 14, 2024
@RichDom2185 RichDom2185 deleted the revert-2281 branch February 14, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants