Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StoriesRole enum #2592

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Update StoriesRole enum #2592

merged 2 commits into from
Aug 4, 2023

Conversation

RichDom2185
Copy link
Member

Description

Updates the frontend enum values (and help messages) following the corresponding backend change in source-academy/stories-backend#63.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-assigned this Aug 3, 2023
@RichDom2185 RichDom2185 enabled auto-merge (squash) August 3, 2023 21:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5756004610

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.454%

Totals Coverage Status
Change from base Build 5727812224: 0.0%
Covered Lines: 5732
Relevant Lines: 14377

💛 - Coveralls

@RichDom2185 RichDom2185 merged commit 0225c9d into master Aug 4, 2023
@RichDom2185 RichDom2185 deleted the update-storiesrole-enum branch August 4, 2023 01:59
RichDom2185 added a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Aug 6, 2023
* Update enum value

* Update help messages
RichDom2185 added a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Aug 15, 2023
* Update enum value

* Update help messages
@coveralls
Copy link

coveralls commented Sep 22, 2024

Pull Request Test Coverage Report for Build 5756004610

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.454%

Totals Coverage Status
Change from base Build 5727812224: 0.0%
Covered Lines: 5732
Relevant Lines: 14377

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants