Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup groups #63

Merged
merged 28 commits into from
Aug 3, 2023
Merged

Setup groups #63

merged 28 commits into from
Aug 3, 2023

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Jul 22, 2023

Part of #15. Part of #18.

@RichDom2185 RichDom2185 self-assigned this Jul 22, 2023
@github-actions
Copy link

github-actions bot commented Jul 22, 2023

Coverage Status

coverage: 50.69% (+1.3%) from 49.37% when pulling 21dd623 on setup-groups into e4486d1 on main.

@YaleChen299 YaleChen299 self-assigned this Jul 23, 2023
Copy link
Contributor

@YaleChen299 YaleChen299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far!

@YaleChen299 YaleChen299 marked this pull request as ready for review July 28, 2023 20:45
RichDom2185 and others added 9 commits July 31, 2023 01:35
* Fix spacing
* Add newline to EOF
* Fix incorrect table name in rollback command
* Replace type with domain
* Fix missing type deletion in rollback command
Removed as they are the default values. Done to improve readability and
clarity.
@YaleChen299 YaleChen299 merged commit 8552c1e into main Aug 3, 2023
@YaleChen299 YaleChen299 deleted the setup-groups branch August 3, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants