Setup basic access control framework #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some logic depends on user role enums and are thus commented out.
* Handle checking of user authorization from within the role permission struct * Create utility function to return the correct authorization level from a specified permission
Adapted from the users' login provider enum.
Done due to the severity of the lack of implementation (breaks entire access control framework).
RichDom2185
changed the title
ngruiyanrena
approved these changes
Jul 26, 2023
YaleChen299
pushed a commit
that referenced
this pull request
Jul 26, 2023
* Create basic permissions structs and package * Create users' permission types * Create users' permission struct * Add users' group role to permissions mapper Some logic depends on user role enums and are thus commented out. * Add top-level permissions checker * Refactor role permissions logic * Handle checking of user authorization from within the role permission struct * Create utility function to return the correct authorization level from a specified permission * Implement CheckPermissions function * Create users' group role enum Adapted from the users' login provider enum. * Integrate Role enum to role permissions check * Replace TODO with FIXME Done due to the severity of the lack of implementation (breaks entire access control framework).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16.
Blocked by #63.Cherry-picked b0f8a30 from #63 so that this PR won't get blocked.