Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@sourceloop/core: Add UserModifyCrudRepository to support loopback4-sequelize #1329

Closed
shubhamp-sf opened this issue Feb 28, 2023 · 0 comments · Fixed by #1330
Closed

@sourceloop/core: Add UserModifyCrudRepository to support loopback4-sequelize #1329

shubhamp-sf opened this issue Feb 28, 2023 · 0 comments · Fixed by #1330

Comments

@shubhamp-sf
Copy link
Contributor

Is your feature request related to a problem? Please describe.

loopback4-soft-delete package will have support of loopback4-sequelize package after merging this PR: sourcefuse/loopback4-soft-delete#119

@sourceloop/core already provides repository for DefaultUserModifyCrudRepository based on existing soft crud repo.

So It should also include similar repository with SequelizeSoftCrudRepository as it's underlying class.

Describe the solution you'd like

Add SequelizeUserModifyCrudRepository in the core package that extends SequelizeSoftCrudRepository from soft delete package with similar functions as default user modify crud repository.

Describe alternatives you've considered
Can also have a mixin that accepts any repository similar to soft crud repository.
shubhamp-sf added a commit that referenced this issue Feb 28, 2023
@shubhamp-sf
feat(core): add user modify crud repository for sequelize
15b0b51 
Export `SequelizeSoftCrudRepository` extending `SequelizeSoftCrudRepository` from soft-delete package

GH-1329
@shubhamp-sf shubhamp-sf mentioned this issue Feb 28, 2023
Merged
9 tasks
shubhamp-sf added a commit that referenced this issue Feb 28, 2023
@shubhamp-sf
feat(core): add user modify crud repository for sequelize
d41e142 
Export `SequelizeSoftCrudRepository` extending `SequelizeSoftCrudRepository` from soft-delete package

GH-1329
shubhamp-sf added a commit that referenced this issue Mar 1, 2023
@shubhamp-sf
feat(core): add user modify crud repository for sequelize
d1ff0f9 
Export `SequelizeSoftCrudRepository` extending `SequelizeSoftCrudRepository` from soft-delete package

GH-1329
shubhamp-sf added a commit that referenced this issue Mar 1, 2023
@shubhamp-sf
feat(core): add user modify crud repository for sequelize
2a78276 
Export `SequelizeUserModifyCrudRepository` extending `SequelizeSoftCrudRepository`

GH-1329
shubhamp-sf added a commit that referenced this issue Mar 1, 2023
@shubhamp-sf
feat(core): add user modify crud repository for sequelize
5e7bc04 
Export `SequelizeUserModifyCrudRepository` extending `SequelizeSoftCrudRepository`

GH-1329
shubhamp-sf added a commit that referenced this issue Mar 2, 2023
@shubhamp-sf
feat(core): add user modify crud repository for sequelize
d46a8cc 
Export `SequelizeUserModifyCrudRepository` extending `SequelizeSoftCrudRepository`

GH-1329
yeshamavani pushed a commit that referenced this issue Mar 2, 2023
@shubhamp-sf
feat(core): add user modify crud repository for sequelize (#1330)
f22d81e 
Export `SequelizeUserModifyCrudRepository` extending `SequelizeSoftCrudRepository`

GH-1329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): add user modify crud repository for sequelize sourcefuse/loopback4-microservice-catalog
1 participant
@shubhamp-sf