Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add user modify crud repository for sequelize #1330

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

shubhamp-sf
Copy link
Contributor

@shubhamp-sf shubhamp-sf commented Feb 28, 2023

Description

Added export to SequelizeUserModifyCrudRepository extending SequelizeSoftCrudRepository from soft-delete package in directory import syntax.

Users will be able to use it from importing it like:

import {SequelizeUserModifyCrudRepository} from '@sourceloop/core/sequelize';

GH-1329

Fixes #1329

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@shubhamp-sf shubhamp-sf force-pushed the GH-1329 branch 4 times, most recently from 2a78276 to 5e7bc04 Compare March 1, 2023 13:54
@shubhamp-sf shubhamp-sf marked this pull request as ready for review March 1, 2023 13:59
@shubhamp-sf shubhamp-sf requested a review from yeshamavani March 1, 2023 13:59
Export `SequelizeUserModifyCrudRepository` extending `SequelizeSoftCrudRepository`

GH-1329
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
32.9% 32.9% Duplication

@yeshamavani yeshamavani merged commit f22d81e into master Mar 2, 2023
@yeshamavani yeshamavani deleted the GH-1329 branch March 2, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sourceloop/core: Add UserModifyCrudRepository to support loopback4-sequelize
2 participants