Enhance German translation (2) #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ fix some typos and add missing translations
NilsPvR
commented
Aug 9, 2024
warappa
reviewed
Aug 9, 2024
|
Hi @NilsPvR, I'm done reviewing. I left some comments but hopefully they are helpful for you! |
|
Hey @warappa, thanks for the extensive review and all the added sources 💪. Was quite busy yesterday so I went through the comments now. I'll make a new PR once the last suggestions are resolved, since this PR is already merged. |
|
Hi @NilsPvR, I think I'm through again. Thank you for the good collaboration! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue I went through the German translations and found some things which could be improved. I'll add a review to this PR to comment on my suggestions for the translations. I won't add any comments on the simple typos.
A code review by @warappa would be greatly appreciated.
Fixes #331