Skip to content

style(locale): Translate to French Batch 2 #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

UchiTesting
Copy link
Contributor

A second batch of translation for French locale.

The translation should be roughly 2/3 to completion.

Bellow is a non exhaustive list of changes.

Diff.SyntaxHighlight
RevealFile
Revert
Reword
Running
Save
Stash
URL
UpdateSubmodules
Warn
WorkingCopy
Worktree

Some extra sentences

Include small fixes for
CodeEditor : missing accent
Include a fix mentioned in the previous PR #405 but not merged. (non -> nom for name in a string)

@UchiTesting UchiTesting changed the title style(locale): Translate to French Batch 1 style(locale): Translate to French Batch 2 Aug 31, 2024
@UchiTesting
Copy link
Contributor Author

UchiTesting commented Aug 31, 2024

Good evening.

Can I use the occasion to ask a question?

In the confirmation dialog to drop a stash, I see a "On" term I cannot understand where it comes from.

image

There are 2 strings that contain such text but they are both followed by a colon (:) and changing them did not help.

I should translate this to "sur"

The code seems to be located in Views/DropStash.axaml but I can't find where the "On" comes from.

      <StackPanel Grid.Column="1" Orientation="Horizontal">
        <Path Width="12" Height="12" Margin="0,0,8,0"
              HorizontalAlignment="Left" VerticalAlignment="Center"
              Data="{StaticResource Icons.Stashes}"/>

        <TextBlock VerticalAlignment="Center" Classes="primary" Text="{Binding Stash.SHA, Converter={x:Static c:StringConverters.ToShortSHA}}" Foreground="DarkOrange"/>
        <TextBlock VerticalAlignment="Center" Text="{Binding Stash.Message}" Margin="8,0,0,0"/>
      </StackPanel>

@love-linger
Copy link
Collaborator

I suggest you work with the authors of PR #424 to merge the changes into a final PR.

@love-linger love-linger self-assigned this Sep 1, 2024
@love-linger love-linger added the localization Localization/Translation label Sep 1, 2024
@love-linger
Copy link
Collaborator

Good evening.

Can I use the occasion to ask a question?

In the confirmation dialog to drop a stash, I see a "On" term I cannot understand where it comes from.

image

There are 2 strings that contain such text but they are both followed by a colon (:) and changing them did not help.

I should translate this to "sur"

The code seems to be located in Views/DropStash.axaml but I can't find where the "On" comes from.

      <StackPanel Grid.Column="1" Orientation="Horizontal">
        <Path Width="12" Height="12" Margin="0,0,8,0"
              HorizontalAlignment="Left" VerticalAlignment="Center"
              Data="{StaticResource Icons.Stashes}"/>

        <TextBlock VerticalAlignment="Center" Classes="primary" Text="{Binding Stash.SHA, Converter={x:Static c:StringConverters.ToShortSHA}}" Foreground="DarkOrange"/>
        <TextBlock VerticalAlignment="Center" Text="{Binding Stash.Message}" Margin="8,0,0,0"/>
      </StackPanel>

It's the stash message and added by git automatically. You can see:
image

Text.DeleteMultiBranch.Tip had the term branch in singular instead of plural
Diff.SyntaxHighlight
RevealFile
Revert
Reword
Running
Save
Stash
URL
UpdateSubmodules
Warn
WorkingCopy
Worktree

Some extra sentences

Include small fixes for
CodeEditor : missing accent
@UchiTesting
Copy link
Contributor Author

OK Thanks.
So this can't be helped.

@UchiTesting
Copy link
Contributor Author

UchiTesting commented Sep 7, 2024

I suggest you work with the authors of PR #424 to merge the changes into a final PR.

I saw that. And at first I thought the same. However after a second thought I think we can merge my changes (delta any potential thing to fix) 1st and then go for the improvement batch.
I did comment about it in the other PR too.

I will review the lines submitted there and halt progress with the remaining 3rd of translations on my side.

Capital letter in the beginning was missing.
@love-linger love-linger merged commit 2a59cdb into sourcegit-scm:develop Sep 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Localization/Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants