Update webview theme on editor theme change #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added try/catch when handling theme change event - added logger for ThemeService and WebViewController
|
|
||
| private async void HandleThemeChanges(ThemeChangedEventArgs e) | ||
| { | ||
| try |
There was a problem hiding this comment.
I've added try/catch here :) In general every code that is handling event should be in the try/catch.
Also Task.Delay(100).Wait() was blocking UI thread, so changed the method signature to allow awaiting it.
| "; | ||
|
|
||
| public void SetLogger(ILog logger) | ||
| { |
There was a problem hiding this comment.
Controller can use logger now :)
|
|
||
| public async void OnThemeChanged(object sender, IColorThemeChangedEvent e) | ||
| { | ||
| try |
There was a problem hiding this comment.
Additional try/catch because we're handling event.
PiotrKarczmarz
approved these changes
Sep 5, 2024
… UX) by increasing Task.Delay(1000) (from 100 ms): - Task.Delay() returns code execution to the main UI thread and IDE has enough time to change entire VS Theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE https://linear.app/sourcegraph/issue/CODY-3622/webview-theme-should-update-on-theme-changed
vs_theme_change.mp4
Test Plan:
Try following the steps shown in the demo video above to switch theme and confirm the webview is updated accordingly.