-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cody: change auth endpoint to handle SAMS redirect #2957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Nice work, and world-class test plan!
But don't merge just yet! We need to coordinate some changes together on the server-side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
Edit: Haven't set up an instance to test, will wait for the server side change deployed to test
Converted to draft to prevent mis-merge. |
All server-side changes should be ready now! |
Sister PR of sourcegraph/cody#2957, please that that PR for full detail. ## Test plan Locally tested with sourcegraph.com ![CleanShot 2024-02-01 at 14 22 25@2x](https://github.com/sourcegraph/jetbrains/assets/2946214/062753ff-e8c8-41ab-8836-a6c0e0b82426)
Part of the accounts migration from sourcegraph.com to accounts.sourcegraph.com (SAMS). Using this new auth url that enables us to redirect to SAMS and back to dotcom.
I wasn't able to test the GitLab login properly as my account is too new, could someone help with this?
For more context, see Joe's explanation
Test plan
Pull the branch, make sure you are logged out of sourcegraph.com AND accounts.sourcegraph.com. Head to the editor, log out of Cody, confirm that each login has the right url and try logging in.
See each scenario below:
GitHub
login-github-sams.mp4
GitLab
login-gitlab-sams.mp4
Google
login-google-sams.mp4