Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cody: update auth endpoint for SAMS redirect #3037

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Feb 5, 2024

This is a follow-up improvement to #2957. TIL we can configure auth provider in Sourcegraph to have a static pc to reference to. This is strictly better than relying on the brittle sha256 of current provider config.

Test plan

Manually tested

and

CleanShot 2024-02-05 at 14 55 27@2x

@unknwon unknwon requested review from kalanchan and a team February 5, 2024 19:56
Copy link
Contributor

@kalanchan kalanchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this will help make sure users end up at the right spot to login

@unknwon
Copy link
Member Author

unknwon commented Feb 5, 2024

Merging as-is, happy to address post-merge feedback! (Please tag me on Slack for action items, I have my GitHub notification muted for this repository 🙏 )

@unknwon unknwon merged commit 92bb04b into main Feb 5, 2024
15 checks passed
@unknwon unknwon deleted the unknwon-patch-1 branch February 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants