Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: add billing categorization to cody events 1 #5493

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

dadlerj
Copy link
Member

@dadlerj dadlerj commented Sep 6, 2024

In accordance with RFC 978

Test plan

Low impact change—testing here is only ensuring that this passes CI and builds correctly without errors.

Changelog

@dadlerj dadlerj marked this pull request as ready for review September 7, 2024 03:20
@dadlerj
Copy link
Member Author

dadlerj commented Sep 7, 2024

I tagged a few people for reviews, but none of you have to do a detailed, line-by-line review here. I just wanted to get a few opinions before merging:

  • @bobheadxi confirmation that this looks right to you considering the v2 telemetry architecture
  • @abeatrix confirmation that this change "looks" fine in the context of the Cody codebase
  • @akalia25 just tagged for awareness

More such PRs will be coming for our other codebases, and I've likely missed a few in sourcegraph/cody as well, so this is only an early proof of concept. A bigger announcement about this will come once our existing events have this set up.

Copy link
Member

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! Excited to see this getting used 😁

lib/shared/src/telemetry-v2/index.ts Outdated Show resolved Hide resolved
@dadlerj dadlerj merged commit 9608429 into main Sep 9, 2024
19 checks passed
@dadlerj dadlerj deleted the telemetry-categorizations branch September 9, 2024 16:22
mkondratek pushed a commit to sourcegraph/jetbrains that referenced this pull request Oct 4, 2024
Adds billing metadata to some events per RFC 978:
https://docs.google.com/document/d/1EvyH1kaU-fsn59h-DyoaO2Qy4C2TYLmDGjG73bdb2V4/edit#heading=h.trqab8y0kufp

follow on to sourcegraph/cody#5493 and
sourcegraph/sourcegraph#529

## Test plan

CI

---------

Co-authored-by: Dan Adler <5589410+dadlerj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants