telemetry: Add billing categorization to cody events 2 #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pkukielka ! I'm not sure how to diagnose this—when I run I'd love any recommendations. Thank you. Again, feel free to reassign if there's someone else I should talk to! |
mkondratek
reviewed
Oct 4, 2024
| } | ||
|
|
||
| data class BillingMetadata(val product: BillingProduct, val category: BillingCategory) | ||
|
|
||
| data class TelemetryEventParameters( |
There was a problem hiding this comment.
btw, this protocol class is not generated
interface TelemetryEvent {
feature: string
action: string
parameters?:
| TelemetryEventParameters<{ [key: string]: number }, BillingProduct, BillingCategory>
| undefined
| null
}
It looks like our generating tool does not support fields like parameters in this case. I'd be nice to get it working.
mkondratek
force-pushed
the
tel-billing
branch
from
2913bd8
to
608d7d9
Compare
mkondratek
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
hi @dadlerj 👋 sorry for the delay 🙇
I rebased your branch. I tried your changes. The event are properly sent to the agent 🟢
mkondratek
force-pushed
the
tel-billing
branch
from
608d7d9
to
93e9e91
Compare
|
Thank you @mkondratek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds billing metadata to some events per RFC 978: https://docs.google.com/document/d/1EvyH1kaU-fsn59h-DyoaO2Qy4C2TYLmDGjG73bdb2V4/edit#heading=h.trqab8y0kufp
follow on to sourcegraph/cody#5493 and https://github.com/sourcegraph/sourcegraph/pull/529
Test plan
CI