-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry: Add billing categorization to cody events 2 #2345
Conversation
Hey @pkukielka ! I'm not sure how to diagnose this—when I run I'd love any recommendations. Thank you. Again, feel free to reassign if there's someone else I should talk to! |
} | ||
|
||
data class BillingMetadata(val product: BillingProduct, val category: BillingCategory) | ||
|
||
data class TelemetryEventParameters( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, this protocol class is not generated
interface TelemetryEvent {
feature: string
action: string
parameters?:
| TelemetryEventParameters<{ [key: string]: number }, BillingProduct, BillingCategory>
| undefined
| null
}
It looks like our generating tool does not support fields like parameters
in this case. I'd be nice to get it working.
2913bd8
to
608d7d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @dadlerj 👋 sorry for the delay 🙇
I rebased your branch. I tried your changes. The event are properly sent to the agent 🟢
608d7d9
to
93e9e91
Compare
Thank you @mkondratek ! |
Adds billing metadata to some events per RFC 978: https://docs.google.com/document/d/1EvyH1kaU-fsn59h-DyoaO2Qy4C2TYLmDGjG73bdb2V4/edit#heading=h.trqab8y0kufp
follow on to sourcegraph/cody#5493 and https://github.com/sourcegraph/sourcegraph/pull/529
Test plan
CI