-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change CodyAuthenticationManager from project to application level se…
…rvice (#2190) ## Changes After discussion with @danielmarquespt we decided account settings should be global, shared across all IntelliJ projects. To reflect that fact I'm changing `CodyAuthenticationManager` to be APP level service instead of project level. Notifications about account state change are pushed to all open projects. All projects use shared storage, so changes done when project is closed are also properly loaded upon opening that project. All relevant changes are in the `CodyAuthenticationManager`, all the rest is removal of unneeded `project` parameter. ## Test plan **Scenario 1** 1. Sign-in with any account 2. Restart the IntelliJ 3. Make sure you are still logged in **Scenario 2** 1. Sign-in with any account, add a few more 2. Restart the IntelliJ 3. Make sure you are still logged in, with the same account **Scenario 3** 1. Sign-in with any account, add a few more 2. Switch account 3. Restart the IntelliJ 4. Make sure you are still logged in, with the same account you switched to **Scenario 4** 1. Sign-in with any account, add a few more 2. Sign-out 3. Restart the IntelliJ 4. Make sure you are not logged in **Scenario 5** 1. Sign-in with any account, add a few more 2. Switch account 3. Open a second IntelliJ project 4. Make sure in the second IntelliJ window you are logged in, with the same account you switched to **Scenario 6** 1. Open two IntelliJ projects side by side 2. Open `Account` panel in both of them 3. Make sure that switching account in one of them causes switch to the same account on the second **Scenario 7** 1. Open two IntelliJ projects side by side 2. Open `Account` panel in both of them and make sure they have active the same account 3. Close one of the instances 4. Switch account in the remaining instance 5. Close the second instance and open back the first one 6. Make sure account is properly switched
- Loading branch information
Showing
35 changed files
with
145 additions
and
130 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.