Change CodyAuthenticationManager from project to application level service #2190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After discussion with @danielmarquespt we decided account settings should be global, shared across all IntelliJ projects.
To reflect that fact I'm changing
CodyAuthenticationManager
to be APP level service instead of project level.Notifications about account state change are pushed to all open projects.
All projects use shared storage, so changes done when project is closed are also properly loaded upon opening that project.
All relevant changes are in the
CodyAuthenticationManager
, all the rest is removal of unneededproject
parameter.Test plan
Scenario 1
Scenario 2
Scenario 3
Scenario 4
Scenario 5
Scenario 6
Account
panel in both of themScenario 7
Account
panel in both of them and make sure they have active the same account