-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: pressing UpArrow in multiline message has surprising behavior #1134
Comments
I'm regularly hitting on this bug making it quite annoying to use the chat in JB. I would rather disable the custom up/down arrows than have this buggy behavior. I'm not sure why/when this regressed because I'm pretty sure I tested this thoroughly when we launched it |
Related slack thread: https://sourcegraph.slack.com/archives/C05AGQYD528/p1711718880832439 |
The regression happened in this PR here @pkukielka https://sourcegraph.com/github.com/sourcegraph/jetbrains/-/commit/88a21694097716fbe53b84e76b3124cb3454af76 Specifically, the |
Fixes #1134 Previously, pressing up/down arrow keys in the chat input always replaced the entire contents of the chat input with the previous/next chat message from history. This was a regression that was introduced in the commit https://sourcegraph.com/github.com/sourcegraph/jetbrains/-/commit/88a21694097716fbe53b84e76b3124cb3454af76#diff-91c99de25d8f01dab68bee8fa28fb6f1L80 where the variable `isInHistoryMode` got removed. This PR adds back the original logic for `isInHistoryMode` so the chat input works like before. Demo https://www.loom.com/share/4806fcaeaa9e44519d12e8b6d16a29a0
Fixes #1134 Previously, pressing up/down arrow keys in the chat input always replaced the entire contents of the chat input with the previous/next chat message from history. This was a regression that was introduced in the commit https://sourcegraph.com/github.com/sourcegraph/jetbrains/-/commit/88a21694097716fbe53b84e76b3124cb3454af76#diff-91c99de25d8f01dab68bee8fa28fb6f1L80 where the variable `isInHistoryMode` got removed. This PR adds back the original logic for `isInHistoryMode` so the chat input works like before. ## Test plan Manually tested. See demo https://www.loom.com/share/4806fcaeaa9e44519d12e8b6d16a29a0 <!-- All pull requests REQUIRE a test plan: https://sourcegraph.com/docs/dev/background-information/testing_principles Why does it matter? These test plans are there to demonstrate that are following industry standards which are important or critical for our customers. They might be read by customers or an auditor. There are meant be simple and easy to read. Simply explain what you did to ensure your changes are correct! Here are a non exhaustive list of test plan examples to help you: - Making changes on a given feature or component: - "Covered by existing tests" or "CI" for the shortest possible plan if there is zero ambiguity - "Added new tests" - "Manually tested" (if non trivial, share some output, logs, or screenshot) - Updating docs: - "previewed locally" - share a screenshot if you want to be thorough - Updating deps, that would typically fail immediately in CI if incorrect - "CI" - "locally tested" -->
Cody Version
5.4.6-nightly
IDE Information
Describe the bug
a\n\nb
Expected behavior
I expected the cursor to move up one line in the chat input
Additional context
No response
The text was updated successfully, but these errors were encountered: