Fix bug where up/down arrow keys always navigate chat history #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1134 Previously, pressing up/down arrow keys in the chat input always replaced the entire contents of the chat input with the previous/next chat message from history. This was a regression that was introduced in the commit https://sourcegraph.com/github.com/sourcegraph/jetbrains/-/commit/88a21694097716fbe53b84e76b3124cb3454af76#diff-91c99de25d8f01dab68bee8fa28fb6f1L80 where the variable `isInHistoryMode` got removed. This PR adds back the original logic for `isInHistoryMode` so the chat input works like before. Demo https://www.loom.com/share/4806fcaeaa9e44519d12e8b6d16a29a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1134
Previously, pressing up/down arrow keys in the chat input always replaced the entire contents of the chat input with the previous/next chat message from history. This was a regression that was introduced in the commit https://sourcegraph.com/github.com/sourcegraph/jetbrains/-/commit/88a21694097716fbe53b84e76b3124cb3454af76#diff-91c99de25d8f01dab68bee8fa28fb6f1L80 where the variable
isInHistoryModegot removed. This PR adds back the original logic forisInHistoryModeso the chat input works like before.Test plan
Manually tested. See demo https://www.loom.com/share/4806fcaeaa9e44519d12e8b6d16a29a0