-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update org.jetbrains.intellij 1.15.0 -> 1.17.0 #343
Conversation
@@ -23,7 +23,7 @@ plugins { | |||
id("java") | |||
// Dependencies are locked at this version to work with JDK 11 on CI. | |||
id("org.jetbrains.kotlin.jvm") version "1.9.10" | |||
id("org.jetbrains.intellij") version "1.15.0" | |||
id("org.jetbrains.intellij") version "1.17.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see anything important for us.
https://github.com/JetBrains/gradle-intellij-plugin/releases
@@ -183,16 +181,6 @@ class CodyToolWindowContent(private val project: Project) : UpdatableChat { | |||
} | |||
} | |||
|
|||
private fun getUserId(server: CodyAgentServer): String? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused
@@ -1,3 +1,7 @@ | |||
package com.sourcegraph.cody.agent.protocol | |||
|
|||
data class GetFeatureFlag(val flagName: String) | |||
data class GetFeatureFlag(val flagName: String) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am preparing us to have two more ff here (#319). I tried to make it an enum but it did not work through the request to the agent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
771ccee
to
e02b5f2
Compare
A few minor fixes & updates.
Test plan
:runIde
, test accounts switching & rate limit errors