-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update org.jetbrains.intellij 1.15.0 -> 1.17.0 #343
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
af0a187
Update org.jetbrains.intellij 1.15.0 -> 1.17.0
mkondratek 9e12b6f
Cleanup
mkondratek b67e1e0
Extract GetFeatureFlag constants
mkondratek 886f30a
Update com.diffplug.spotless 6.21.0 -> 6.25.0
mkondratek ab40965
Update org.jetbrains.kotlin.jvm 1.9.10 -> 1.9.22
mkondratek 86df066
Fixe "Failed to convert git clone URL" warn
mkondratek e02b5f2
Fixes
mkondratek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,6 @@ import com.intellij.util.IconUtil | |
import com.intellij.util.concurrency.annotations.RequiresBackgroundThread | ||
import com.intellij.util.concurrency.annotations.RequiresEdt | ||
import com.intellij.xml.util.XmlStringUtil | ||
import com.sourcegraph.cody.agent.CodyAgentServer | ||
import com.sourcegraph.cody.agent.CodyAgentService | ||
import com.sourcegraph.cody.agent.protocol.ChatMessage | ||
import com.sourcegraph.cody.agent.protocol.ContextMessage | ||
|
@@ -130,7 +129,6 @@ class CodyToolWindowContent(private val project: Project) : UpdatableChat { | |
CodyAgentService.applyAgentOnBackgroundThread(project) { agent -> | ||
fetchSubscriptionPanelData(project, agent.server).thenAccept { | ||
if (it != null) { | ||
|
||
ApplicationManager.getApplication().invokeLater { refreshSubscriptionTab(it) } | ||
} | ||
} | ||
|
@@ -183,16 +181,6 @@ class CodyToolWindowContent(private val project: Project) : UpdatableChat { | |
} | ||
} | ||
|
||
private fun getUserId(server: CodyAgentServer): String? { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unused |
||
return server | ||
.currentUserId() | ||
.exceptionally { | ||
logger.warn("Unable to fetch user id from agent") | ||
null | ||
} | ||
.get() | ||
} | ||
|
||
@RequiresEdt | ||
override fun refreshPanelsVisibility() { | ||
val codyAuthenticationManager = CodyAuthenticationManager.instance | ||
|
6 changes: 5 additions & 1 deletion
6
src/main/kotlin/com/sourcegraph/cody/agent/protocol/GetFeatureFlag.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
package com.sourcegraph.cody.agent.protocol | ||
|
||
data class GetFeatureFlag(val flagName: String) | ||
data class GetFeatureFlag(val flagName: String) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am preparing us to have two more ff here (#319). I tried to make it an enum but it did not work through the request to the agent. |
||
companion object { | ||
val CodyProJetBrains = GetFeatureFlag("CodyProJetBrains") | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see anything important for us.
https://github.com/JetBrains/gradle-intellij-plugin/releases