Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust bindings] parse macro symbols #145

Merged
merged 2 commits into from
May 31, 2023

Conversation

wfraser
Copy link
Contributor

@wfraser wfraser commented May 1, 2023

Macros end in an exclamation point. Currently parsing one results in a MissingDescriptor error, for example:

Test plan

dbg!(scip::symbol::parse_symbol("rust-analyzer cargo std https://github.com/rust-lang/rust/library/std macros/print!"));

wfraser and others added 2 commits May 31, 2023 16:06
Macros end in an exclamation point. Currently parsing one results in a MissingDescriptor error, for example:

`scip::symbol::parse_symbol("rust-analyzer cargo std https://github.com/rust-lang/rust/library/std macros/print!")`
@tjdevries
Copy link
Contributor

Sorry for the delay, just added a test and waiting for green. Then I'll merge!

@tjdevries tjdevries merged commit a1a6f89 into sourcegraph:main May 31, 2023
@wfraser
Copy link
Contributor Author

wfraser commented May 31, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants