Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make mock generates invalid fetcher mock #1887

Closed
AndrewSisley opened this issue Sep 15, 2023 · 2 comments · Fixed by #1926
Closed

make mock generates invalid fetcher mock #1887

AndrewSisley opened this issue Sep 15, 2023 · 2 comments · Fixed by #1926
Assignees
@AndrewSisley
Labels
area/testing Related to any test or testing suite bug Something isn't working

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Sep 15, 2023 •
edited
Loading

Steps to reproduce:

  1. make mock
  2. Try and compile the tests, it will fail due to the fetcher mock.
@AndrewSisley AndrewSisley added bug Something isn't working area/testing Related to any test or testing suite labels Sep 15, 2023
@jsimnz
Copy link
Member

jsimnz commented Sep 15, 2023

Can you add context here? How's it invalid?

@AndrewSisley
Copy link
Contributor Author

Sorry I was going to do so once I finished what I was in the middle of, adding now

@AndrewSisley AndrewSisley self-assigned this Oct 4, 2023
@AndrewSisley AndrewSisley mentioned this issue Oct 4, 2023
Merged
AndrewSisley added a commit that referenced this issue Oct 4, 2023
@AndrewSisley
fix(i): Update fetcher mock (#1926)
04a20e3 
## Relevant issue(s)

Resolves #1887

## Description

Updates the fetcher mock.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
fix(i): Update fetcher mock (sourcenetwork#1926)
b9000d9 
## Relevant issue(s)

Resolves sourcenetwork#1887

## Description

Updates the fetcher mock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/testing Related to any test or testing suite bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(i): Update fetcher mock AndrewSisley/defradb
2 participants
@jsimnz @AndrewSisley