Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i): Update fetcher mock #1926

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1887

Description

Updates the fetcher mock.

It was left out of date after I removed a couple of the funcs from the interface in 0.7.

@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite code quality Related to improving code quality labels Oct 4, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.8 milestone Oct 4, 2023
@AndrewSisley AndrewSisley requested a review from a team October 4, 2023 16:42
@AndrewSisley AndrewSisley self-assigned this Oct 4, 2023
Was out of date
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3f9decc) 74.74% compared to head (84e3eea) 74.65%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1926      +/-   ##
===========================================
- Coverage    74.74%   74.65%   -0.10%     
===========================================
  Files          234      234              
  Lines        23114    23114              
===========================================
- Hits         17276    17254      -22     
- Misses        4660     4677      +17     
- Partials      1178     1183       +5     
Flag Coverage Δ
all-tests 74.65% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9decc...84e3eea. Read the comment docs.

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@AndrewSisley AndrewSisley merged commit 04a20e3 into sourcenetwork:develop Oct 4, 2023
@AndrewSisley AndrewSisley deleted the 1887-fetcher-mock branch October 4, 2023 19:11
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#1887

## Description

Updates the fetcher mock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make mock generates invalid fetcher mock
2 participants