Fix all warnings from running with PYTHONDEVMODE #974
Labels
Comments
|
281 warnings running |
luizirber
added a commit
that referenced
this issue
Nov 25, 2023
Address #974 (comment), down from 281 warnings to 24 after dib-lab/screed#106 is merged and a new `screed` version is available. Most warnings were `ResourceWarnings` for unclosed files in tests, but there were a couple in `src/sourmash` too. Preferred to use a context manager with `screed.open` or when passing the file to another library (like `numpy`), but for tests changed a lot of code to use `Path(...).read_text().splitlines()` instead. The remaining 24 warnings are due to duplicate files in `ZipStorage`, punting it for later because they will require more attention when modifying `src/sourmash/sbt_storage.py`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Python 3.8 job in Travis runs with
PYTHONDEVMODEenabled. This returns a lot of warnings at the moment, so fixing them might be a good idea =]Example: https://travis-ci.com/github/dib-lab/sourmash/jobs/325347193#L1127
Can also be run locally with
PYTHONDEVMODE=1 make testThe text was updated successfully, but these errors were encountered: