Fix many warning from PYTHONDEVMODE=1
#2849
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #974 (comment), down from 281 warnings to 24 after dib-lab/screed#106 is merged and a new
screed
version is available.Most warnings were
ResourceWarnings
for unclosed files in tests, but there were a couple insrc/sourmash
too. Preferred to use a context manager withscreed.open
or when passing the file to another library (likenumpy
), but for tests changed a lot of code to usePath(...).read_text().splitlines()
instead.The remaining 24 warnings are due to duplicate files in
ZipStorage
, punting it for later because they will require more attention when modifyingsrc/sourmash/sbt_storage.py
.