Added ability to remove nssm parameters #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
Would you mind rebasing? |
You can now remove previously set nssm parameters by setting the hash values to '' for Strings, & 0 for Integers. Also improved how the Consul service is stopped on Windows. If you don't stop it before you remove it, you end up in a SERVICE_PAUSED state.
If nssm reported SERVICE_PAUSED for the consul service, the nssm resource was unable to remove it. Altered the service status check so it's flexible to handle multiple exit statuses.
It appears the nssm resource also isn't idempotent. I also added another attribute and made it the default value for the install_path property for consul_service. My reasoning is that one should be able to change this crucial property without having to redeclare the whole resource. #262 will be fixed for linux once johnbellone/libartifact-cookbook#2 is merged
`new_resource.notifies(:reload, new_resource, :delayed)` causes the `consul_service` resource to reload every time Chef ran. This is an issue with the new sysvinit service provider when the service is in a stopped state when Chef runs. It would start and recieve a reload HUP too quickly & subsequently crash the service.
@legal90 kindly pointed out that the default value for ['consul']['config']['data_dir'] & ['consul']['service']['data_dir'] was changed to append 'data' as the last folder. Consul actually creates this directory for you when you start the service. And if you didn't change both, it could cause the Consul agent to fail.
|
Done. |
|
The tests pass locally on my machine. It looks like a one-off issue. |
johnbellone
added a commit
that referenced
this pull request
Feb 3, 2016
Added ability to remove nssm parameters
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
''for Strings, &0for Integers. Also improved how the Consul service is stopped on Windows. If you don't stop it before you remove it, you end up in a SERVICE_PAUSED state.new_resource.notifies(:reload, new_resource, :delayed)causes theconsul_serviceresource to reload every time Chef ran. This is an issue with the new sysvinit service provider when the service is in a stopped state when Chef runs. It would start and recieve a reload HUP too quickly & subsequently crash the service.consul_serviceresource. My reasoning is that one should be able to change this crucial property without having to redeclare the whole resource.