Remove duplicated "data_dir" attribute

[legal90]

I guess it was just a typo in #259
We already have ['config']['data_dir'], so ['service']['data_dir'] is not needed.

Otherwise it could cause a Consul agent start failure if you override only the one of these attributes.

cc: @Ginja

[codecov-io]

Current coverage is 61.90%

Merging #269 into master will increase coverage by +13.23% as of f1abf0c

@@            master   #269   diff @@
=====================================
  Files            7      7       
  Stmts          378    378       
  Branches         0      0       
  Methods          0      0       
=====================================
+ Hit            184    234    +50
  Partial          0      0       
+ Missed         194    144    -50

Review entire Coverage Diff as of f1abf0c

Powered by Codecov. Updated on successful CI builds.

[Ginja]

Good catch! I override both of these values in our own environment. I'll change this in #263 in case @johnbellone wants to keep ['consul']['service']['data_dir'].

[legal90]

@Ginja Could you please explain what is the original purpose of ['consul']['service']['data_dir'] ?
Why don't you use ['consul']['config']['data_dir'] for that?

[Ginja]

I can't unfortunately, I was simply modifying what was already there. I don't see a need for it, and am happy to eject it in my PR as well if @johnbellone would like.

[legal90]

Well... I just thought that it was your idea, because this attribute has been added in your commit:
https://github.com/visioncritical/consul-cookbook/commit/ad2fcf5f291f0d325dc3f11d8530c7871dc8337a#diff-25e5d4a4446ae12a0d6f1162b6160375R36

[Ginja]

Ha, wow. I've been working on this too long I don't even remember what I've done. I also need more coffee.

I added this so I could modify this attribute without overriding the whole resource. Makes it easier to use cross-platform:

https://github.com/visioncritical/consul-cookbook/commit/ad2fcf5f291f0d325dc3f11d8530c7871dc8337a#diff-e7d95569a41fab7bae4ab723c764c914L60
https://github.com/johnbellone/consul-cookbook/blob/master/recipes/default.rb#L55

[scalp42]

Seeing the same issue here. Changed our data dir location.

[Ginja]

I've updated #263 to change it back to just data_prefix_path, which is the original value.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.