Fixing UI Installation #306

miroswan · 2016-04-04T23:50:01Z

I believe /var/lib/consul needs to exist in order to symlink /opt/consul-webui/$VERSION to /var/lib/consul/ui. This was failing for me prior to adding the directory resource to the LWRP for web-ui installation.

miroswan · 2016-04-05T00:15:41Z

Looks like the tests need to be fixed themselves.

Ginja · 2016-04-05T14:42:56Z

Thanks for the PR! A few requests:

Could you change the directory resource so it's not hardcoded, but rather reflects where it's being symlinked (see below)?
Could you add a resource to remove the directory in action_remove?
If you wouldn't mind taking a shot at fixing the tests that'd be awesome, but don't sweat it.

base = ::File.dirname options[:symlink_to]
# => /var/lib/consul

directory base

miroswan · 2016-04-07T21:49:47Z

I can take a shot at this later in the week.

miroswan · 2016-04-11T10:47:16Z

I fixed my tests locally and updated travis.yml in attempt to fix the faraday situation. Don't think travis is configured to run subsequent builds against this PR so it's hard to tell if my changes will fix the faraday issue as well.

-- Edit --
Travis is updating, but bundle update did not help.

…ut keep a valid version of poise-boiler

miroswan · 2016-04-11T22:06:26Z

It appears that faraday 0.9.0 is having problems. When I bump it down to 0.8.0, the problem goes away, but then poise-boiler reverts to version 0. Seems like a strange dependency issue.

Since the ConsulInstallationWebui provider relies on non-core chef resources, we can't use an inline recipe. ``` 1) ConsulCookbook::Provider::ConsulInstallationWebui webui installation Failure/Error: it do is_expected.to unzip_zipfile('consul_0.6.4_web_ui.zip') .with(source: 'https://releases.hashicorp.com/consul/0.6.4/consul_0.6.4_web_ui.zip', path: '/opt/consul-webui/0.6.4') end NoMethodError: consul_installation[0.6.4] (/Users/user/github/chef-consul/test/spec/libraries/consul_installation_webui_spec.rb line 12) had an error: NoMethodError: No resource or method named `zipfile' for `ConsulCookbook::Provider::ConsulInstallationWebui ""' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/dsl/recipe.rb:102:in `rescue in method_missing' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/dsl/recipe.rb:99:in `method_missing' # ./libraries/consul_installation_webui.rb:50:in `block in action_create' # ./libraries/consul_installation_webui.rb:45:in `action_create' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/provider.rb:144:in `run_action' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/resource.rb:596:in `run_action' # ./.bundle/ruby/2.2.0/gems/chefspec-4.6.0/lib/chefspec/extensions/chef/resource.rb:22:in `run_action' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/runner.rb:73:in `run_action' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/runner.rb:105:in `block (2 levels) in converge' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/runner.rb:105:in `each' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/runner.rb:105:in `block in converge' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/resource_collection/resource_list.rb:84:in `block in execute_each_resource' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/resource_collection/stepable_iterator.rb:116:in `call' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/resource_collection/stepable_iterator.rb:116:in `call_iterator_block' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/resource_collection/stepable_iterator.rb:85:in `step' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/resource_collection/stepable_iterator.rb:104:in `iterate' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/resource_collection/resource_list.rb:82:in `execute_each_resource' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/runner.rb:104:in `converge' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/client.rb:668:in `block in converge' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/client.rb:663:in `catch' # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/client.rb:663:in `converge' # ./.bundle/ruby/2.2.0/gems/chefspec-4.6.0/lib/chefspec/solo_runner.rb:126:in `converge' # ./test/spec/libraries/consul_installation_webui_spec.rb:17:in `block (3 levels) in <top (required)>' # ------------------ # --- Caused by: --- # NoMethodError: # undefined method `zipfile' for #<ConsulCookbook::Provider::ConsulInstallationWebui:0x007fc246a8ee80> # ./.bundle/ruby/2.2.0/gems/chef-12.8.1/lib/chef/dsl/recipe.rb:100:in `method_missing' ```

Fix consul logging for sysvinit provider

The poise inversion system needs to be added to consul_service otherwise windows tests will not pass

Gemfile

+# Referencing https://github.com/nomad/shenzhen/issues/96 to
+# fix build issue regarding the faraday gem
+group :faraday do
+  gem 'faraday', '~> 0.8.0'


shortdudey123 · 2016-04-19T00:28:42Z

Tests are correctly fixed in #305

Fix webui installation spec test

Base name should be appended by "386" for all x86 platforms, including "i686".

consul_installation: Fix binary base url for Linux x86

Prevent "consul" service to be restarted on update

shortdudey123 · 2016-04-25T18:26:47Z

@miroswan can you rebase on master? several tests have been fixed causing your merge conflicts

miroswan · 2016-05-06T05:34:46Z

Hadn't checked in on this in a while. I'll take a look at this soon.

…ut keep a valid version of poise-boiler

miroswan · 2016-05-06T10:12:17Z

I rebased as requested, but it appears that some previous commits from upstream (for which I am not the author) have snuck into my PR. Outside of that, the tests are passing.

miroswan · 2016-05-09T01:41:08Z

I think I'm going to do a fresh PR since it's a small change.

miroswan · 2016-05-09T02:17:23Z

It appears that someone added my fix from a different branch. Just waiting for the next release to the supermarket now.

gdavison · 2016-05-09T05:15:05Z

Yeah, I hadn't noticed you'd submitted a PR when I created mine. If you had anything in your PR that you think should be added, go ahead.

lock · 2020-04-25T09:12:23Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Need the root directory to exist for the symlink

a894c8d

Demitri Swan added 2 commits April 11, 2016 03:27

Fixing tests

bc7e032

Trying a bundle update

6228c7f

Demitri Swan added 8 commits April 11, 2016 04:06

Trying w/ ChefDK

3b9f538

Trying to update Berkshelf

1aeb4de

Temporarily Disabling codeclimate

435b4a8

Locking down faraday to attempt fixing build issue

9adba45

Locking down faraday to attempt fixing build issue

5ccee38

Got rake travis working locally. Trying in travis

2dded6e

Need to clear the cache so poise-boiler gets picked up

945fa3d

Looks like faraday version 9 is having the issue. Need to drop to 8 b…

f60dcee

…ut keep a valid version of poise-boiler

legal90 and others added 7 commits April 15, 2016 12:12

Fix consul logging for sysvinit provider

c66698f

Prevent "consul" service to be restarted on update

75f76d6

Merge pull request #308 from legal90/fox-logging

5735613

Fix consul logging for sysvinit provider

Travis needs berkshelf 4+

520c3c1

Fix windows test

7319ffa

Disable consul_service tests for windows

9443c07

The poise inversion system needs to be added to consul_service otherwise windows tests will not pass

shortdudey123 reviewed Apr 19, 2016
View reviewed changes

Gemfile

# Referencing https://github.com/nomad/shenzhen/issues/96 to

# fix build issue regarding the faraday gem

group :faraday do

gem 'faraday', '~> 0.8.0'

This comment was marked as outdated.

Sign in to view

johnbellone and others added 4 commits April 18, 2016 21:41

Merge pull request #305 from shortdudey123/fix_webui_spec_test

37a82ac

Fix webui installation spec test

Fix binary base url for x86 platform

a182c98

Base name should be appended by "386" for all x86 platforms, including "i686".

Merge pull request #310 from legal90/fix-x86

6dd7907

consul_installation: Fix binary base url for Linux x86

Merge pull request #309 from legal90/fix-restart

026f86f

Prevent "consul" service to be restarted on update

Demitri Swan added 13 commits May 6, 2016 00:01

Need the root directory to exist for the symlink

76c340b

Fixing tests

386bd37

Trying a bundle update

8135d52

Trying w/ ChefDK

dad6bc6

Trying to update Berkshelf

b6e62ce

Temporarily Disabling codeclimate

65c5b09

Locking down faraday to attempt fixing build issue

b1b8982

Locking down faraday to attempt fixing build issue

425792a

Got rake travis working locally. Trying in travis

de42531

Need to clear the cache so poise-boiler gets picked up

991433e

Looks like faraday version 9 is having the issue. Need to drop to 8 b…

3877279

…ut keep a valid version of poise-boiler

No need for pinning faraday. Also removing poise-boiler pin

4e4b7fb

Save point

981a4ef

miroswan closed this May 9, 2016

lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing UI Installation #306

Fixing UI Installation #306

miroswan commented Apr 4, 2016

miroswan commented Apr 5, 2016

Ginja commented Apr 5, 2016

miroswan commented Apr 7, 2016

miroswan commented Apr 11, 2016

miroswan commented Apr 11, 2016

This comment was marked as outdated.

shortdudey123 commented Apr 19, 2016

shortdudey123 commented Apr 25, 2016

miroswan commented May 6, 2016

miroswan commented May 6, 2016

miroswan commented May 9, 2016

miroswan commented May 9, 2016

gdavison commented May 9, 2016

lock bot commented Apr 25, 2020

Fixing UI Installation #306

Fixing UI Installation #306

Conversation

miroswan commented Apr 4, 2016

miroswan commented Apr 5, 2016

Ginja commented Apr 5, 2016

miroswan commented Apr 7, 2016

miroswan commented Apr 11, 2016

miroswan commented Apr 11, 2016

This comment was marked as outdated.

shortdudey123 commented Apr 19, 2016

shortdudey123 commented Apr 25, 2016

miroswan commented May 6, 2016

miroswan commented May 6, 2016

miroswan commented May 9, 2016

miroswan commented May 9, 2016

gdavison commented May 9, 2016

lock bot commented Apr 25, 2020