Fix installation on arm machines #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legal90
reviewed
Oct 4, 2016
| @@ -86,6 +86,7 @@ def self.binary_basename(node, resource) | |||
| case node['kernel']['machine'] | |||
| when 'x86_64', 'amd64' then ['consul', resource.version, node['os'], 'amd64'].join('_') | |||
| when /i\d86/ then ['consul', resource.version, node['os'], '386'].join('_') | |||
| when /^arm/ then ['consul', resource.version, node['os'], 'arm'].join('_') | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Current coverage is 68.01% (diff: 100%)
|
legal90
approved these changes
Oct 5, 2016
|
@legal90 Whats with the failing travis checks. I saw that master is failing as well. |
|
I'm not sure, but #348 could be a reason of Travis CI build failures. cc: @johnbellone |
|
@rollbrettler Thanks for the contribution! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no
armv7lpackage only aarmpackage, therefore this throws an error.