Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert lvm_physical_volume resource to unified_mode #210

Conversation

jasonwbarnett
Copy link

@jasonwbarnett jasonwbarnett commented Oct 5, 2021

Description

Convert lvm_physical_volume resource to unified_mode

Issues Resolved

This resolves issues in CI pipelines that depend on this cookbook and are testing using Chef Infra Client 17 with test-kitchen configured with deprecations_as_errors: true

Check List

Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
@jasonwbarnett
Copy link
Author

@lamont-granquist @tas50 as an alternative to this I could open up a PR in https://github.com/chef/chef to get this resource added into the core of Chef Infra Client. Thoughts?

@tas50
Copy link
Contributor

tas50 commented Oct 5, 2021

@jasonwbarnett I'd love to get this one in core, but I think it needs a pretty extensive rewrite first

@jasonwbarnett
Copy link
Author

jasonwbarnett commented Oct 5, 2021

@jasonwbarnett I'd love to get this one in core, but I think it needs a pretty extensive rewrite first

You good merging this in and cutting a new major release?

@damacus
Copy link
Member

damacus commented Oct 6, 2021

We need to adopt this into sous first. Maybe either @ramereth, @xorima or @bmhughes can do it?

@ramereth
Copy link
Contributor

ramereth commented Oct 7, 2021

Yup, working on it

@ramereth
Copy link
Contributor

This was fixed in #213

@ramereth ramereth closed this Oct 14, 2021
@jasonwbarnett jasonwbarnett deleted the bugfix/update-for-unified_mode branch October 20, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants