-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sous Chefs Adoption #213
Merged
Merged
Sous Chefs Adoption #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues found and resolved with: test/fixtures/cookbooks/test/resources/loop_devices.rb - 1:1 refactor: Chef/Deprecations/ResourceWithoutUnifiedTrue - Set unified_mode true in Chef Infra Client 15.3+ custom resources to ensure they work correctly in Chef Infra Client 18 April 2022 when Unified Mode becomes the default. https://docs.chef.io/workstation/cookstyle/chef_deprecations_resourcewithoutunifiedtrue Signed-off-by: kitchen-porter <board@sous-chefs.org>
Signed-off-by: kitchen-porter <board@sous-chefs.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
0109324
to
1fcfb18
Compare
tas50
reviewed
Oct 13, 2021
detjensrobert
previously requested changes
Oct 13, 2021
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Let's ignore these for now so we can ship out a release as-is. Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Apparently 1 is too small on Ubuntu 20.04 and mkfs fails Signed-off-by: Lance Albertson <lance@osuosl.org>
1eeefee
to
e24f889
Compare
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
xorima
approved these changes
Oct 14, 2021
Released as: 5.1.0 |
This was referenced Oct 14, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hacktoberfest
An issue highlighted for the digital ocean Hacktoberfest Event
hacktoberfest-accepted
PR has been accepted for hacktoberfest 2020. Waiting on merge
Release: Minor
Release to Chef Supermarket as a minor release when merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cookbook in line with sous-chefs standards