Make exit code success when Steep has unreported type errors #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably it fixes #158
problem
Steep exits with status code 1 unexpectedly. The cause is type-checking options.
Steep CLI filters type errors by this option.
steep/lib/steep/drivers/check.rb
Line 56 in 33f507b
But the option does not affect the exit status code.
Becuase it checks
target.errors.empty?
buttarget.errors
contains unreported type errors.steep/lib/steep/drivers/check.rb
Line 67 in 33f507b
solution
Remove unreported type errors from
Steep::Project::Target#errors
.