Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rocker does not respect container users #146

Closed
Bckempa opened this issue Apr 29, 2024 · 0 comments · Fixed by #147
Closed

Rocker does not respect container users #146

Bckempa opened this issue Apr 29, 2024 · 0 comments · Fixed by #147
Assignees
@Bckempa @mkhansenbot
Milestone
humble-2024.04.0

Comments

@Bckempa
Copy link
Contributor

Bckempa commented Apr 29, 2024

The rocker Docker container launcher used by the demos does not respect non-root users managed by the underlying containers. Trying to use the --user-override-name flag creates a new user instead.

Potential Fixes:

  1. Add a change of user to the entrypoint.sh scripts
  2. Evaluate if we really need rocker, we don't seem to be using it
@Bckempa Bckempa added this to the humble-2024.04.0 milestone Apr 29, 2024
mkhansenbot added a commit to mkhansenbot/docker that referenced this issue Apr 29, 2024
@mkhansenbot
Remove rocker - fix issue space-ros#146)
39b0610
@mkhansenbot mkhansenbot mentioned this issue Apr 29, 2024
Merged
mkhansenbot added a commit to mkhansenbot/docker that referenced this issue Apr 29, 2024
@mkhansenbot
Remove rocker - fix issue space-ros#146
125edfd
mkhansenbot added a commit to mkhansenbot/docker that referenced this issue Apr 29, 2024
@mkhansenbot
Remove rocker - fix issue space-ros#146
32779e1
@Bckempa Bckempa linked a pull request Apr 29, 2024 that will close this issue
Remove rocker - fix issue #146 #147
Merged
mkhansenbot added a commit to mkhansenbot/docker that referenced this issue Apr 30, 2024
@mkhansenbot
Remove rocker - fix issue space-ros#146
1f85724
mkhansenbot added a commit that referenced this issue Apr 30, 2024
@mkhansenbot
Merge pull request #147 from mkhansenbot/remove_rocker
abf6552 
Remove rocker - fix issue #146
eholum pushed a commit to eholum/space-ros that referenced this issue Jun 26, 2024
@mkhansenbot @eholum
Remove rocker - fix issue space-ros/docker#146
6b13e08
eholum pushed a commit to eholum/space-ros that referenced this issue Jun 26, 2024
@mkhansenbot
Remove rocker - fix issue space-ros/docker#146
0c0029f
eholum pushed a commit to eholum/space-ros that referenced this issue Jun 26, 2024
@mkhansenbot
Remove rocker - fix issue space-ros/docker#146
89a41e8
@rcywongaa rcywongaa mentioned this issue Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bckempa Bckempa

@mkhansenbot mkhansenbot

Labels
None yet
Projects
Space ROS Project Development
Status: Done
Milestone
humble-2024.04.0
Development

Successfully merging a pull request may close this issue.

Remove rocker - fix issue #146 mkhansenbot/docker
2 participants
@Bckempa @mkhansenbot