Remove rocker - fix issue #146 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you remove the |
mkhansenbot
force-pushed
the
remove_rocker
branch
2 times, most recently
from
125edfd to
32779e1
Compare
|
I've tested this as far as I can - building and running work, with the exception of the GUI which has never worked on my setup. I can put a green check here but really someone who can run the GUI should see it spin up to be safe. |
Bckempa
approved these changes
Apr 29, 2024
|
@quarkytale - can you test it also? I think it's good to merge but would like you to verify if possible |
mkhansenbot
force-pushed
the
remove_rocker
branch
from
32779e1 to
1f85724
Compare
quarkytale
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove rocker from run.sh files to fix issue #146