Fix melee audio on entity destruction #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udio System and changed Client Audio System to use a coordinate instead of an entity for sound location
…udio System and changed Client Audio System to use a coordinate instead of an entity for sound location
SoulSloth
requested review from
Acruid,
PJB3005 and
ZoldorfTheWizard
as code owners
|
I think it should probably use the coordinates as a fallback if getting the entity failed. If you don't it's possible when chasing someone that the sound of their shooting will come from behind you instead of in front. |
Yeah sounds right. Forgot that |
…FixMeleeAudioOnEntityDestruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1191.
Adds a coordinate to
PlayAudioEntityMessageand changes theplayfunction on the client audio system to no longer rely on an entity that may be deleted.Can't be tested until space-wizards/space-station-14#1494 is complete as the exception it fixes supersedes this issue.