Moved audio playing for melee to be before damage calculation #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acruid
approved these changes
Jul 28, 2020
TheArturZh
referenced
this pull request
in TheArturZh/space-station-14
Oct 13, 2023
Morb0
added a commit
to Morb0/space-station-14
that referenced
this pull request
Oct 24, 2023
Morb0
pushed a commit
to Morb0/space-station-14
that referenced
this pull request
Oct 24, 2023
Erisfiregamer1
pushed a commit
to The-Arcadis-Team/arc-station-14
that referenced
this pull request
Jan 11, 2025
Found it. Had to trace everything calling the Ai Whitelist component, and found this system was closing all UIs if you weren't an AI and were trying to interact with a computer with said whitelist component.
rhit-eppersac
pushed a commit
to Kandiyaki/space-station-14
that referenced
this pull request
Feb 10, 2025
Dog Accent Rework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1492.
There's another issue were audio on the client side won't play on destruction of an object, but that's a separate issue with RobustToolbox I'll have a PR out for shortly.