-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exceeding an object's damage threshold causes exception #1492
Labels
T: Bugfix
Type: Bugs and/or bugfixes
Comments
Moved the audio playing logic before the damage calculation in MeleeComponent, however objects are deleted on the client before they can play the audio when they're destroyed. |
Fixed by #1494 |
rbertoche
pushed a commit
to rbertoche/space-station-14
that referenced
this issue
Apr 22, 2023
Why is it even here?
Morb0
pushed a commit
to Morb0/space-station-14
that referenced
this issue
Oct 24, 2023
rbertoche
pushed a commit
to rbertoche/space-station-14
that referenced
this issue
Jun 24, 2024
* Fix Mechs * Update Content.Server/Mech/Systems/MechSystem.cs Was Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Update Content.Server/Mech/Systems/MechSystem.cs Sure Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Update Content.Shared/Mech/EntitySystems/SharedMechSystem.cs Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> --------- Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
Erisfiregamer1
pushed a commit
to The-Arcadis-Team/arc-station-14
that referenced
this issue
Jan 11, 2025
…pace-wizards#1492) <!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Adds incompatibility to ensure that someone cannot take negative visual traits while having cyber-eyes systems, and likewise cannot take redundant negative visual traits. Should resolve [this issue](Simple-Station/Einstein-Engines#1327). --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p> ![githubphotophobiaimage](https://github.com/user-attachments/assets/fd27ac82-d4b5-4c67-a4ad-35c6be9862b4) </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - fix: You cannot take Photophobia while blind or you have cyber-eyes. - fix: You cannot take nearsightedness while blind or while having cyber-eyes. - fix: You cannot be blind while nearsighted, photophobic, or while having cyber-eyes.
Erisfiregamer1
pushed a commit
to The-Arcadis-Team/arc-station-14
that referenced
this issue
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduction steps:
DebugAssertException: Tried to get component on a deleted entity
This is probably due to the fact that the audio system tries to get the object's location after it's marked as deleted.
The text was updated successfully, but these errors were encountered: