Tiles can now be modified by arbitrary tool qualities #12738
Conversation
# Conflicts: # Content.Server/Tools/Components/LatticeCuttingComponent.cs # Content.Server/Tools/Components/TilePryingComponent.cs
|
Draft because big + tiles are important + sill making sure I got everything + ratio |
Mervill
requested review from
PJB3005,
DrSmugleaf,
ElectroJr,
mirrorcult,
gradientvera and
moonheart08
as code owners
github-actions
bot
added
the
S: Needs Review
|
ok so this actually dosen't have any merge conflicts two months later? how is that even possible... |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
S: Merge Conflict
| if (component.RequiresUnobstructed && tileRef.IsBlockedTurf(true)) | ||
| return; | ||
|
|
||
| if (tileRef.TryDeconstructWithToolQualities(tool.Qualities, _mapManager, _tileDefinitionManager, EntityManager)) |
There was a problem hiding this comment.
this function should just get moved to being in the same system, i doubt it will be called elsehwere? (also the other tileref methods in this same vein were removed in a diff PR)
mirrorcult
added
S: Awaiting Changes
|
@Mervill are you coming back to this |
metalgearsloth
added
the
S: Derelict
|
Right, so, of this PR, I've managed to get the following two parts merged:
Which leaves:
The problem is I'm not actually sure about this approach. Does it actually make sense to have a tool that has the qualities of a crowbar but doesn't work on tiles for some reason? If it does, what about the inverse? |
About the PR
This is a big refactor about Tiles. The focus is to make it so that Tiles can now define arbitrary tool qualities for modifying them. This replaces the existing and somewhat snowflake-y
canCrowbarandcanWirecutterpathways for modifying Tiles.canCrowbarandcanWirecutteron Tiles has been replaced withdeconstructToolQualitieswhich is a list that defines what tool qualities can cause a tile to switch to itsbaseTurfLatticeCuttingandTilePryinghave been combined intoToolWorksWithTileswhich allows an object that also has theToolcomponent to work on tiles.baseTurfper Tile instead of a list of turfs.underPlatingis now completely depreciatedThis PR contains no gameplay changes. In the future I hope certain construction focused forks will let me rip up plating without having to resort to explosives.