Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize tile prying to any tool quality #24432

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

EmoGarbage404
Copy link
Member

About the PR

Revival of #12738
Removes CanCrowbar, CanWirecutter, and CanAxe.

Holy shit how many of these were we gonna add before making this generic. This changes all of those fields to just be a single DeconstructTools list.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

For tiles:

  • canCrowbar has become deconstructTools: [ Prying ]
  • canWireCutter has become deconstructTools: [ Cutting ]
  • canAxe is just gone

for tools:

  • TilePryingComponent and WireCuttingComponent have been combined into just ToolTileCompatibleComponent.

Changelog

no cl no fun

@mirrorcult
Copy link
Contributor

probably should cl for axe pry removal

@EmoGarbage404
Copy link
Member Author

probably should cl for axe pry removal

the axe had it removed earlier today. all this is doing is removing the remaining code.

@mirrorcult
Copy link
Contributor

oh epic then

@mirrorcult mirrorcult merged commit 5e2e652 into space-wizards:master Jan 23, 2024
9 of 10 checks passed
DrMelon pushed a commit to DrMelon/space-station-14 that referenced this pull request Jan 24, 2024
* Generalize tile prying to any tool quality

* ballin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants