Make radio jammer block suit sensors #26046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S: Needs Review
|
Great change that turns the Radio Jammer from a somewhat useful to a very useful maints slasher item. Will definitely start using it more in the future if this gets implemented. |
|
Does this work with tracking implants as well? Also looks like I'm gonna have to figure out merge conflicts for REAL this time 😆. |
Yes. |
|
I just realized the event should just use CancellableEntityEventArgs however I'm dumb. I'll fix it tomorrow when I wake up. Or not, not enough sleep to figure it out currently. |
Use CancellableEventArgs instead of doing what the hell I was doing before.
metalgearsloth
approved these changes
Mar 13, 2024
|
me like |
metalgearsloth
added
S: Awaiting Changes
Change the event from a CancellableEntityEventArgs to a ByRefEvent.
github-actions
bot
added
S: Needs Review
Merged
VMSolidus
pushed a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
May 9, 2024
## Mirror of PR #26046: [Make radio jammer block suit sensors](space-wizards/space-station-14#26046) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `dce24dfd03b3ddfe1044297edf9d35bc9f75c523` PR opened by <img src="https://avatars.githubusercontent.com/u/32041239?v=4" width="16"/><a href="https://github.com/nikthechampiongr"> nikthechampiongr</a> at 2024-03-12 17:11:18 UTC --- PR changed 5 files with 36 additions and 5 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Radio jammers will now additionally block suit sensors. > > When someone with suit sensors is in range of an active radio jammer, their suit sensor output will be jammed. This will lead to them appearing as frozen on any crew monitors for roughly 10 seconds before they completely disappear from it. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > This gives syndies more stealth options when doing their objectives, and provides an interesting use for the radio jammer. > > Now on the implementation details: > > With this current implementation you drop off suit sensors after roughly 10 seconds of being jammed. This means you get a 10 second period before anyone actively watching crew monitors can even suspect something's wrong. The reason I have it like this is: > a) It's the simplest way to implement this feature. > b) It's more realistic while still providing a pretty significant advantage. > > Alternatively this could be changed to make the suit sensors submit outdated info indefinitely until the jammer has stopped. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > Added a new event which the suit sensors system calls before actually constructing the message it will send to the crew monitoring server. If it is cancelled then the message is not sent. I also intentionally made it so this is checked after a new update time has been set, but if it's a problem it can just be moved above it. > > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > https://github.com/space-wizards/space-station-14/assets/32041239/3bc815ac-5ec1-4ef1-8594-b390da657d29 > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > 🆑 > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > 🆑 > - tweak: The radio jammer is now able to jam the signal of suit sensors. </details> Co-authored-by: SimpleStation14 <Unknown>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Radio jammers will now additionally block suit sensors.
When someone with suit sensors is in range of an active radio jammer, their suit sensor output will be jammed. This will lead to them appearing as frozen on any crew monitors for roughly 10 seconds before they completely disappear from it.
Why / Balance
This gives syndies more stealth options when doing their objectives, and provides an interesting use for the radio jammer.
Now on the implementation details:
With this current implementation you drop off suit sensors after roughly 10 seconds of being jammed. This means you get a 10 second period before anyone actively watching crew monitors can even suspect something's wrong. The reason I have it like this is:
a) It's the simplest way to implement this feature.
b) It's more realistic while still providing a pretty significant advantage.
Alternatively this could be changed to make the suit sensors submit outdated info indefinitely until the jammer has stopped.
Technical details
Added a new event which the suit sensors system calls before actually constructing the message it will send to the crew monitoring server. If it is cancelled then the message is not sent. I also intentionally made it so this is checked after a new update time has been set, but if it's a problem it can just be moved above it.
Media
2024-03-12.19-07-00.mp4
Changelog
🆑