Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix medical PDA/health analyzer long range intel bug #31879

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

goet
Copy link
Contributor

@goet goet commented Sep 6, 2024

About the PR

Fixes #31863.
Content Client_513ApX78nx

Why / Balance

Currently the health analyzer can be used as a global alive/dead tracker.

Technical details

Hides the SpriteView if the scan becomes inactive, shows an out of range sprite if the SpriteView is hidden.

Media

scanner2.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • fix: Hides character sprite in health analyzer window if the scan becomes inactive.

@github-actions github-actions bot added the Changes: UI Changes: Might require knowledge of UI design or code. label Sep 6, 2024
@metalgearsloth metalgearsloth merged commit 24ed1f7 into space-wizards:master Sep 21, 2024
11 checks passed
Ilya246 pushed a commit to Ilya246/space-station-14 that referenced this pull request Oct 7, 2024
…1879)

* hide spriteview from health analyzer while inactive

* add out of range indicator if analyzer becomes inactive

* hide out of range icon if there is no patient data
VMSolidus pushed a commit to Simple-Station/Einstein-Engines that referenced this pull request Nov 7, 2024
# Description

Does what it says on the can, ports over the updates to the Health
Analyzer made in Wizden's
[#30834](space-wizards/space-station-14#30834),
[#31879](space-wizards/space-station-14#31879),
and
[#32636](space-wizards/space-station-14#32636)
because I need them for newmed


Credit to [Floof
#169](Fansana/floofstation1#169) too since I
yoinked it due to lazyness :trollface:

---

# Changelog

🆑 Mocho
- tweak: Ported over Wizden's updated Health Analyzer UI.

---------

Co-authored-by: FoxxoTrystan <45297731+FoxxoTrystan@users.noreply.github.com>
Co-authored-by: goet <6637097+goet@users.noreply.github.com>
Co-authored-by: Saphire Lattice <lattice@saphi.re>
Erisfiregamer1 pushed a commit to The-Arcadis-Team/arc-station-14 that referenced this pull request Nov 9, 2024
…1879)

* hide spriteview from health analyzer while inactive

* add out of range indicator if analyzer becomes inactive

* hide out of range icon if there is no patient data
sleepyyapril pushed a commit to Grimbly-Station/Grimbly-Station that referenced this pull request Nov 10, 2024
# Description

Does what it says on the can, ports over the updates to the Health
Analyzer made in Wizden's
[#30834](space-wizards/space-station-14#30834),
[#31879](space-wizards/space-station-14#31879),
and
[#32636](space-wizards/space-station-14#32636)
because I need them for newmed


Credit to [Floof
#169](Fansana/floofstation1#169) too since I
yoinked it due to lazyness :trollface:

---

# Changelog

🆑 Mocho
- tweak: Ported over Wizden's updated Health Analyzer UI.

---------

Co-authored-by: FoxxoTrystan <45297731+FoxxoTrystan@users.noreply.github.com>
Co-authored-by: goet <6637097+goet@users.noreply.github.com>
Co-authored-by: Saphire Lattice <lattice@saphi.re>
Spatison pushed a commit to WWhiteDreamProject/wwdpublic that referenced this pull request Nov 19, 2024
# Description

Does what it says on the can, ports over the updates to the Health
Analyzer made in Wizden's
[#30834](space-wizards/space-station-14#30834),
[#31879](space-wizards/space-station-14#31879),
and
[#32636](space-wizards/space-station-14#32636)
because I need them for newmed

Credit to [Floof
#169](Fansana/floofstation1#169) too since I
yoinked it due to lazyness :trollface:

---

# Changelog

🆑 Mocho
- tweak: Ported over Wizden's updated Health Analyzer UI.

---------

Co-authored-by: FoxxoTrystan <45297731+FoxxoTrystan@users.noreply.github.com>
Co-authored-by: goet <6637097+goet@users.noreply.github.com>
Co-authored-by: Saphire Lattice <lattice@saphi.re>
(cherry picked from commit ffdaa849940263d578d61d8f023efc0898f140f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: UI Changes: Might require knowledge of UI design or code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDA/medical scanner long range intel
2 participants