-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health analyzer unrevivability warning #32636
Add health analyzer unrevivability warning #32636
Conversation
Amazing idea but I'm not sure I like the wording... Also does it differentiate between totally catatonic and just ssd (Yellow vs purple)? At least in delta, you can only biomass people if the are completely catatonic so its kind of an important distinction. |
This specifically only shows info about the "unrevivable" trait. It does not consider catatonics, rotting or etc. Just the trait. You can defib purple catatonics just fine, they'll just not be awake. Unrevivable trait though prevents using defib entirely. Which this warns about. |
Ah the text makes a lot more sense then! |
Kid named Cognizine. |
I don't like this bc it removes the point of the trait. its meant to be a surprise. its meant to infuriate med. if this were to be added it should added when surgery becomes a thing. |
Defib before treating meta continues then? |
Absolutely not. If med cared, and the trait was prevalent enough, they would just defib before treating to test for the composition. They can currently already do this at the cost of some time and like 5 shock damage, all this PR does is make it easier to check. |
I just don't like how obvious it is |
Pretty sure this is exactly the kind of thing that needs to be very obvious. Having it suddenly jumpscare you after you defib is just... Odd? Like, this is the kind of stuff people would wear prominent tags or tattoos for. Medical records is something that really needs to happen, yeah, but that's sideways discussion to this. Related, but not really something conflicting. Also this will allow medical to prioritize this one critical person they won't be able to defib, than letting them die only to Pikachu Face when defib fails. |
i heavily dislike the idea of an optional trait that only exists to make ONE job slightly harder. i view the trait more like a challenge for playing your character. don't die, or you're out of the round. makes things riskier and inclines people to not get into direct combat as often... whereas if the point of it is just to make medical mad, that just ends up feeling like bad game design, to be honest. |
Thanks, this looks like a nice QOL addition for medical Code looks fine and tested in-game fine |
Yeah, felt like there's no indication about it until after you try to revive someone, so there we go. Biggest concern code-wise is that I've made the alerts container (or the text entries in it) fixed width so they don't expand when you stretch the window ...but I'm not sure I've ever done that in ~50 hours of medbay playtime |
Honestly, I wouldn't worry too much about it |
* Add flash reaction effect (space-wizards#32377) add flash reaction effect * Automatic changelog update * Fix loneop spawnrate by reverting it to not use the shuttle event system. (space-wizards#32942) Fix loneop spawnrate by reverting it to not use the custom shuttle event system. * Automatic changelog update * add atmosia to devmap (space-wizards#32460) change * bowls now make drinking sounds (space-wizards#32819) * Automatic changelog update * Add health analyzer unrevivability warning (space-wizards#32636) * Add health analyzer unrevivability warning * Remove errornous comment * Automatic changelog update * Removed the name "Hujsak" (space-wizards#32998) removed hujsak * Update Credits (space-wizards#33016) Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> * fix pie throwing sound not playing (space-wizards#33017) * Automatic changelog update --------- Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> Co-authored-by: BramvanZijp <56019239+BramvanZijp@users.noreply.github.com> Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com> Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com> Co-authored-by: Saphire Lattice <lattice@saphi.re> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# Description Does what it says on the can, ports over the updates to the Health Analyzer made in Wizden's [#30834](space-wizards/space-station-14#30834), [#31879](space-wizards/space-station-14#31879), and [#32636](space-wizards/space-station-14#32636) because I need them for newmed Credit to [Floof #169](Fansana/floofstation1#169) too since I yoinked it due to lazyness --- # Changelog 🆑 Mocho - tweak: Ported over Wizden's updated Health Analyzer UI. --------- Co-authored-by: FoxxoTrystan <45297731+FoxxoTrystan@users.noreply.github.com> Co-authored-by: goet <6637097+goet@users.noreply.github.com> Co-authored-by: Saphire Lattice <lattice@saphi.re>
* Add health analyzer unrevivability warning * Remove errornous comment
* Add health analyzer unrevivability warning * Remove errornous comment
# Description Does what it says on the can, ports over the updates to the Health Analyzer made in Wizden's [#30834](space-wizards/space-station-14#30834), [#31879](space-wizards/space-station-14#31879), and [#32636](space-wizards/space-station-14#32636) because I need them for newmed Credit to [Floof #169](Fansana/floofstation1#169) too since I yoinked it due to lazyness --- # Changelog 🆑 Mocho - tweak: Ported over Wizden's updated Health Analyzer UI. --------- Co-authored-by: FoxxoTrystan <45297731+FoxxoTrystan@users.noreply.github.com> Co-authored-by: goet <6637097+goet@users.noreply.github.com> Co-authored-by: Saphire Lattice <lattice@saphi.re>
# Description Does what it says on the can, ports over the updates to the Health Analyzer made in Wizden's [#30834](space-wizards/space-station-14#30834), [#31879](space-wizards/space-station-14#31879), and [#32636](space-wizards/space-station-14#32636) because I need them for newmed Credit to [Floof #169](Fansana/floofstation1#169) too since I yoinked it due to lazyness --- # Changelog 🆑 Mocho - tweak: Ported over Wizden's updated Health Analyzer UI. --------- Co-authored-by: FoxxoTrystan <45297731+FoxxoTrystan@users.noreply.github.com> Co-authored-by: goet <6637097+goet@users.noreply.github.com> Co-authored-by: Saphire Lattice <lattice@saphi.re> (cherry picked from commit ffdaa849940263d578d61d8f023efc0898f140f6)
About the PR
Added a warning about unrevivability of the patient when scanning them
Why / Balance
Nobody wants to use up half of the medbay's topicals on an atmos tech that was in a fire, only to discover they can not be revived. Something something medical records?
Technical details
Added yet another field into health analyzer UI message. Changed a bit of the health analyzer UI. Also the bleeding warning FTL is now using formatting.
Media
Requirements
Changelog
🆑