Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add atmosia to devmap #32460

Merged
merged 1 commit into from
Oct 26, 2024
Merged

add atmosia to devmap #32460

merged 1 commit into from
Oct 26, 2024

Conversation

Ilya246
Copy link
Contributor

@Ilya246 Ilya246 commented Sep 26, 2024

About the PR

gives devmap an atmos compartment, replaces the fueled generator with a debug generator, moves some lockers around, adds frezon miner prototype

Why / Balance

easier atmos testing

Media

Dev-0

Requirements

Changelog
no cl

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. labels Sep 26, 2024
@lzk228
Copy link
Contributor

lzk228 commented Sep 26, 2024

well.. we already have testteg map, but adding it to dev wouldn't hurt i suppose

@Ilya246
Copy link
Contributor Author

Ilya246 commented Sep 26, 2024

well.. we already have testteg map, but adding it to dev wouldn't hurt i suppose

this doesn't just have teg but everything for convenient atmos testing including a gas miner for every gas, a burnchamber (plasmafire included aka 9 instant plasmafire markers), and a room ready for testing how spacing interacts with an air vent

@Ilya246
Copy link
Contributor Author

Ilya246 commented Oct 21, 2024

it's been almost a month and it doesn't seem like anyone is looking at this, so bump

should be pretty useful if merged since atmos PRs began appearing more actively recently

@chromiumboy chromiumboy self-assigned this Oct 21, 2024
@chromiumboy chromiumboy added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Oct 21, 2024
@superjj18
Copy link

Normalize putting things in the test map.

honestly if you left some notes around, you could probably make it a tutorial map

@chromiumboy chromiumboy removed the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Oct 26, 2024
@chromiumboy chromiumboy merged commit 5a10bf0 into space-wizards:master Oct 26, 2024
12 checks passed
@chromiumboy
Copy link
Contributor

Thank you for your contribution!

@Ilya246 Ilya246 deleted the devmapatmos branch October 26, 2024 03:33
GitHubUser53123 pushed a commit to RonRonstation/ronstation that referenced this pull request Oct 26, 2024
* Add flash reaction effect (space-wizards#32377)

add flash reaction effect

* Automatic changelog update

* Fix loneop spawnrate by reverting it to not use the shuttle event system. (space-wizards#32942)

Fix loneop spawnrate by reverting it to not use the custom shuttle event system.

* Automatic changelog update

* add atmosia to devmap (space-wizards#32460)

change

* bowls now make drinking sounds (space-wizards#32819)

* Automatic changelog update

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: BramvanZijp <56019239+BramvanZijp@users.noreply.github.com>
Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com>
Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com>
GitHubUser53123 pushed a commit to RonRonstation/ronstation that referenced this pull request Oct 27, 2024
* Add flash reaction effect (space-wizards#32377)

add flash reaction effect

* Automatic changelog update

* Fix loneop spawnrate by reverting it to not use the shuttle event system. (space-wizards#32942)

Fix loneop spawnrate by reverting it to not use the custom shuttle event system.

* Automatic changelog update

* add atmosia to devmap (space-wizards#32460)

change

* bowls now make drinking sounds (space-wizards#32819)

* Automatic changelog update

* Add health analyzer unrevivability warning (space-wizards#32636)

* Add health analyzer unrevivability warning

* Remove errornous comment

* Automatic changelog update

* Removed the name "Hujsak" (space-wizards#32998)

removed hujsak

* Update Credits (space-wizards#33016)

Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>

* fix pie throwing sound not playing (space-wizards#33017)

* Automatic changelog update

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: BramvanZijp <56019239+BramvanZijp@users.noreply.github.com>
Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com>
Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com>
Co-authored-by: Saphire Lattice <lattice@saphi.re>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
iaada pushed a commit to iaada/space-station-14 that referenced this pull request Nov 9, 2024
Doctor-Cpu pushed a commit to Doctor-Cpu/space-station-14 that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants