bowls now make drinking sounds #32819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Changes: No C#
|
O7 crunchy water, hello slurpy rice and pork |
in my testing rice still made eating sounds. Didn't test pork but it's probably the same. |
slarticodefast
approved these changes
Oct 16, 2024
slarticodefast
added
the
S: Approved
|
Thanks for the fix! |
|
I tested it and seems like soups and other water based dishes still have eating sounds. But pure liquids have slurping as intended |
|
This doesn't fix all the issues, but its a step in the right direction |
GitHubUser53123
pushed a commit
to RonRonstation/ronstation
that referenced
this pull request
Oct 26, 2024
* Add flash reaction effect (space-wizards#32377) add flash reaction effect * Automatic changelog update * Fix loneop spawnrate by reverting it to not use the shuttle event system. (space-wizards#32942) Fix loneop spawnrate by reverting it to not use the custom shuttle event system. * Automatic changelog update * add atmosia to devmap (space-wizards#32460) change * bowls now make drinking sounds (space-wizards#32819) * Automatic changelog update --------- Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> Co-authored-by: BramvanZijp <56019239+BramvanZijp@users.noreply.github.com> Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com> Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com>
GitHubUser53123
pushed a commit
to RonRonstation/ronstation
that referenced
this pull request
Oct 27, 2024
* Add flash reaction effect (space-wizards#32377) add flash reaction effect * Automatic changelog update * Fix loneop spawnrate by reverting it to not use the shuttle event system. (space-wizards#32942) Fix loneop spawnrate by reverting it to not use the custom shuttle event system. * Automatic changelog update * add atmosia to devmap (space-wizards#32460) change * bowls now make drinking sounds (space-wizards#32819) * Automatic changelog update * Add health analyzer unrevivability warning (space-wizards#32636) * Add health analyzer unrevivability warning * Remove errornous comment * Automatic changelog update * Removed the name "Hujsak" (space-wizards#32998) removed hujsak * Update Credits (space-wizards#33016) Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> * fix pie throwing sound not playing (space-wizards#33017) * Automatic changelog update --------- Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> Co-authored-by: BramvanZijp <56019239+BramvanZijp@users.noreply.github.com> Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com> Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com> Co-authored-by: Saphire Lattice <lattice@saphi.re> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
iaada
pushed a commit
to iaada/space-station-14
that referenced
this pull request
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Bowls, which can be filled with fluid, now make a drinking sound when drank from. No longer can you eat water.
Conveniently they still make an eating sound when filled with food (IE used in cooking recipe) so that's a plus as well.
Why / Balance
Fixes #32224
Technical details
Media
Requirements
Breaking changes
Changelog
🆑