Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace obsolete GetTilesIntersecting methods #32455

Merged
merged 8 commits into from
Dec 1, 2024
Merged

Replace obsolete GetTilesIntersecting methods #32455

merged 8 commits into from
Dec 1, 2024

Conversation

MilenVolf
Copy link
Contributor

@MilenVolf MilenVolf commented Sep 26, 2024 •
edited
Loading

About the PR

Title
I'm planning to remove usage of other obsolete methods in MapGridComponent.

Why / Balance

For #33279

Requirements

Changelog

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Sep 26, 2024
@MilenVolf MilenVolf changed the title Remove usage of obsolete GetTilesIntersecting methods Replace obsolete GetTilesIntersecting methods Sep 29, 2024
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MilenVolf
Merge branch 'master' of https://github.com/space-wizards/space-stati…
7df9d12 
…on-14 into remove-obsolete-GetTilesIntersecting

# Conflicts:
#	Content.Server/Singularity/EntitySystems/EventHorizonSystem.cs
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 29, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@eoineoineoin eoineoineoin added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 22, 2024
@MilenVolf MilenVolf mentioned this pull request Nov 27, 2024
Open
@metalgearsloth metalgearsloth merged commit 5fdf03c into space-wizards:master Dec 1, 2024
11 of 12 checks passed
@MilenVolf MilenVolf mentioned this pull request Dec 1, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 PJB3005 approved these changes

@EmoGarbage404 EmoGarbage404 Awaiting requested review from EmoGarbage404

@TheShuEd TheShuEd Awaiting requested review from TheShuEd TheShuEd is a code owner

Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MilenVolf @PJB3005 @eoineoineoin @metalgearsloth @SlamBamActionman