Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong system usage #33679

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Fix wrong system usage #33679

merged 1 commit into from
Dec 1, 2024

Conversation

MilenVolf
Copy link
Contributor

About the PR

Fixes null exception made in #32455

Why / Balance

Technical details

Media

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 1, 2024
slarticodefast
slarticodefast approved these changes Dec 1, 2024
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!
I'm renaming your PR title since this only needs to be merged into master, not into stable. We use the term hotfix for changes to stable outside the normal releases.

@slarticodefast slarticodefast self-assigned this Dec 1, 2024
@slarticodefast slarticodefast added the P0: Critical Priority: Servers-on-fire important, when it needs to be merged yesterday, or NOW. label Dec 1, 2024
@slarticodefast slarticodefast changed the title [HOTFIX] Fix wrong system usage Fix wrong system usage Dec 1, 2024
@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Dec 1, 2024
@MilenVolf
Copy link
Contributor Author

Thanks for the quick fix! I'm renaming your PR title since this only needs to be merged into master, not into stable. We use the term hotfix for changes to stable outside the normal releases.

Got it

@Partmedia Partmedia merged commit d4067bc into space-wizards:master Dec 1, 2024
14 checks passed
@MilenVolf MilenVolf deleted the 01-12-2024-hotfix branch December 1, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

@Partmedia Partmedia Partmedia approved these changes

Assignees

@slarticodefast slarticodefast

Labels
P0: Critical Priority: Servers-on-fire important, when it needs to be merged yesterday, or NOW. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MilenVolf @Partmedia @slarticodefast